Messages in this thread | | | Subject | Re: [PATCH] tools lib traceevent: Fix missed freeing of subargs in free_arg() in filter | From | Namhyung Kim <> | Date | Mon, 01 Oct 2012 22:16:35 +0900 |
| |
Hi Steve,
2012-09-28 (금), 19:21 -0400, Steven Rostedt: > Some of args were missed in free_args(), as well as subargs. > That is args like FILTER_ARG_NUM have left and right pointers to > other args that also need to be freed. > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > --- > tools/lib/traceevent/parse-filter.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c > index ad17855..2d907cb 100644 > --- a/tools/lib/traceevent/parse-filter.c > +++ b/tools/lib/traceevent/parse-filter.c > @@ -209,7 +209,12 @@ static void free_arg(struct filter_arg *arg) > switch (arg->type) { > case FILTER_ARG_NONE: > case FILTER_ARG_BOOLEAN: > + break; > + > case FILTER_ARG_NUM: > + case FILTER_ARG_EXP: > + free_arg(arg->op.left); > + free_arg(arg->op.right);
Although they have same layout, wouldn't it be better using their own fields?
case FILTER_ARG_NUM: free_arg(arg->num.left); free_arg(arg->num.right); break;
case FILTER_ARG_EXP: free_arg(arg->exp.left); free_arg(arg->exp.right); break;
Thanks, Namhyung
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |