Messages in this thread | | | Date | Fri, 27 Jan 2012 21:07:13 -0500 (EST) | Subject | Re: [PATCH 2/2] net caif: Register properly as a pernet subsystem. | From | David Miller <> |
| |
From: ebiederm@xmission.com (Eric W. Biederman) Date: Thu, 26 Jan 2012 16:04:53 -0800
> > caif is a subsystem and as such it needs to register with > register_pernet_subsys instead of register_pernet_device. > > Among other problems using register_pernet_device was resulting in > net_generic being called before the caif_net structure was allocated. > Which has been causing net_generic to fail with either BUG_ON's or by > return NULL pointers. > > A more ugly problem that could be caused is packets in flight why the > subsystem is shutting down. > > To remove confusion also remove the cruft cause by inappropriately > trying to fix this bug. > > With the aid of the previous patch I have tested this patch and > confirmed that using register_pernet_subsys makes the failure go away as > it should. > > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Applied.
| |