Messages in this thread | | | Date | Fri, 27 Jan 2012 21:07:06 -0500 (EST) | Subject | Re: [PATCH 1/2] netns: Fail conspicously if someone uses net_generic at an inappropriate time. | From | David Miller <> |
| |
From: ebiederm@xmission.com (Eric W. Biederman) Date: Thu, 26 Jan 2012 16:02:55 -0800
> By definition net_generic should never be called when it can return > NULL. Fail conspicously with a BUG_ON to make it clear when people mess > up that a NULL return should never happen. > > Recently there was a bug in the CAIF subsystem where it was registered > with register_pernet_device instead of register_pernet_subsys. It was > erroneously concluded that net_generic could validly return NULL and > that net_assign_generic was buggy (when it was just inefficient). > Hopefully this BUG_ON will prevent people to coming to similar erroneous > conclusions in the futrue. > > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Applied.
| |