Messages in this thread | | | Date | Fri, 27 Jan 2012 10:40:05 -0800 | From | Jesse Barnes <> | Subject | Re: [PATCH 2/5] Dynamic ID addition doesn't need get_driver() |
| |
On Tue, 24 Jan 2012 13:34:41 -0500 (EST) Alan Stern <stern@rowland.harvard.edu> wrote:
> As part of the removal of get_driver()/put_driver(), this patch > (as1511) changes all the places that add dynamic IDs for drivers. > Since these additions are done by writing to the drivers' sysfs > attribute files, and the attributes are removed when the drivers are > unregistered, there is no reason to take an extra reference to the > drivers. > > The one exception is the pci-stub driver, which calls pci_add_dynid() > as part of its registration. But again, there's no reason to take an > extra reference here, because the driver can't be unloaded while it is > being registered.
Looks fine, you can add my ack too.
Thanks, -- Jesse Barnes, Intel Open Source Technology Center [unhandled content-type:application/pgp-signature] | |