Messages in this thread | | | Date | Wed, 25 Jan 2012 20:33:46 +0100 | From | Dominik Brodowski <> | Subject | Re: [PATCH 2/5] Dynamic ID addition doesn't need get_driver() |
| |
On Tue, Jan 24, 2012 at 01:34:41PM -0500, Alan Stern wrote: > As part of the removal of get_driver()/put_driver(), this patch > (as1511) changes all the places that add dynamic IDs for drivers. > Since these additions are done by writing to the drivers' sysfs > attribute files, and the attributes are removed when the drivers are > unregistered, there is no reason to take an extra reference to the > drivers. > > The one exception is the pci-stub driver, which calls pci_add_dynid() > as part of its registration. But again, there's no reason to take an > extra reference here, because the driver can't be unloaded while it is > being registered. > > Signed-off-by: Alan Stern <stern@rowland.harvard.edu> > CC: Dmitry Torokhov <dmitry.torokhov@gmail.com> > CC: Jiri Kosina <jkosina@suse.cz> > CC: Jesse Barnes <jbarnes@virtuousgeek.org> > CC: Dominik Brodowski <linux@dominikbrodowski.net>
For the PCMCIA part: Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
Thanks, Dominik
| |