Messages in this thread Patch in this message | | | From | David Sharp <> | Subject | [PATCH] trace-cmd: fix length calculation for padding events | Date | Thu, 26 Jan 2012 19:00:15 -0800 |
| |
Padding events store size in bytes, not words. Usually this ends up pushing the parser off the current page, but occasionally not, and when not, it ends up desynchronizing the parser from the event stream. This would manifest as a lot of "ug!" messages from trace-cmd, and kernelshark crashing before displaying the UI.
Signed-off-by: David Sharp <dhsharp@google.com> --- trace-input.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/trace-input.c b/trace-input.c index e3157a7..b6af1e6 100644 --- a/trace-input.c +++ b/trace-input.c @@ -1458,7 +1458,6 @@ translate_data(struct pevent *pevent, switch (type_len) { case RINGBUF_TYPE_PADDING: *length = data2host4(pevent, *ptr); - *length *= 4; *ptr += *length; break; -- 1.7.7.3
| |