lkml.org 
[lkml]   [2012]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] trace-cmd: fix length calculation for padding events
Date
Padding events store size in bytes, not words. Usually this ends up pushing
the parser off the current page, but occasionally not, and when not,
it ends up desynchronizing the parser from the event stream. This would
manifest as a lot of "ug!" messages from trace-cmd, and kernelshark
crashing before displaying the UI.

Signed-off-by: David Sharp <dhsharp@google.com>
---
trace-input.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/trace-input.c b/trace-input.c
index e3157a7..b6af1e6 100644
--- a/trace-input.c
+++ b/trace-input.c
@@ -1458,7 +1458,6 @@ translate_data(struct pevent *pevent,
switch (type_len) {
case RINGBUF_TYPE_PADDING:
*length = data2host4(pevent, *ptr);
- *length *= 4;
*ptr += *length;
break;

--
1.7.7.3


\
 
 \ /
  Last update: 2012-01-27 04:11    [W:0.037 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site