lkml.org 
[lkml]   [2012]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + kmod-avoid-deadlock-by-recursive-kmod-call.patch added to -mm tree
> @@ -449,6 +460,16 @@ int call_usermodehelper_exec(struct subp
> retval = -EBUSY;
> goto out;
> }
> + /*
> + * Worker thread must not wait for khelper thread at below
> + * wait_for_completion() if the thread was created with CLONE_VFORK
> + * flag, for khelper thread is already waiting for the thread at
> + * wait_for_completion() in do_fork().
> + */
> + if (wait != UMH_NO_WAIT && current == kmod_thread_locker) {
> + retval = -EBUSY;
> + goto out;
> + }

So, this is because khelper_wq's max_active == 1.

Can't we simply kill khelper_wq and use system_unbound_wq instead?

Oleg.



\
 
 \ /
  Last update: 2012-01-26 20:19    [W:0.043 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site