lkml.org 
[lkml]   [2011]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] add slice by 8 algorithm to crc32.c
Date
Same for x86. The code for the pre and post cleanup loops are the same
there.

> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> Sent: Monday, August 08, 2011 6:11 AM
> To: George Spelvin
> Cc: akpm@linux-foundation.org; fzago@systemfabricworks.com; linux-
> kernel@vger.kernel.org; rpearson@systemfabricworks.com
> Subject: Re: [PATCH] add slice by 8 algorithm to crc32.c
>
> "George Spelvin" <linux@horizon.com> wrote on 2011/08/08 12:52:01:
> >
> > > I prefer to keep the current code which (at the time) generated good
> code
> > > for at least ppc:
> > > /* Align it */
> > > if (unlikely((long)buf & 3 && len)) {
> > > do {
> > > DO_CRC(*buf++);
> > > } while ((--len) && ((long)buf)&3);
> > > }
> >
> > Ah, I was looking at fzago's initial patch; I hadn't realized you'd
> > tweaked it. That's pretty much what I was talking about.
> >
> > Would
> > if (unlikely((long)buf & 3) && len) {
> >
> > give the compiler better hints? len != 0 is awfully
> > likely, actually.
>
> Doesn't matter on ppc(gcc 4.4.4). The whole while loop is moved out of
line
> in both cases and the generated asm is identical.




\
 
 \ /
  Last update: 2011-08-08 19:07    [W:0.063 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site