lkml.org 
[lkml]   [2011]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/1] fs-writeback: Using spin_lock to check for work_list empty
Date
The bdi_writeback_thread function does not use spin_lock to
see if the work_list is empty.

If the list is not empty, and if an interrupt happens before we
set the current->state to TASK_RUNNING then we could be stuck in
a schedule() due to kernel preemption.

This patch acquires and releases the wb_lock to avoid this scenario.

Signed-off-by: Rajan Aggarwal <rajan.aggarwal85@gmail.com>
---
fs/fs-writeback.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 04cf3b9..e333898 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -936,11 +936,14 @@ int bdi_writeback_thread(void *data)
if (pages_written)
wb->last_active = jiffies;

+ spin_lock_bh(&bdi->wb_lock);
set_current_state(TASK_INTERRUPTIBLE);
if (!list_empty(&bdi->work_list) || kthread_should_stop()) {
__set_current_state(TASK_RUNNING);
+ spin_unlock_bh(&bdi->wb_lock);
continue;
}
+ spin_unlock_bh(&bdi->wb_lock);

if (wb_has_dirty_io(wb) && dirty_writeback_interval)
schedule_timeout(msecs_to_jiffies(dirty_writeback_interval * 10));
--
1.7.4.1


\
 
 \ /
  Last update: 2011-08-31 07:15    [W:1.072 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site