Messages in this thread | | | Date | Thu, 25 Aug 2011 13:44:31 +0900 | Subject | RFC : mmc : Use wait_for_completion_timeout() instead of wait_for_completion in case of multiple write blocks. | From | NamJae Jeon <> |
| |
Hi.
If card is infinitely holding pull down busy line(data 0) while writing multiple blocks, write will be blocked in mmc_wait_for_req_done(). I suggest to use wait_for_completion_timeout instread of wait_for_completion like the below code.
How do you think about my suggestion ?
Thanks.
------------------------------------------------------------------------------------------------------------------ static void mmc_wait_for_req_done(struct mmc_host *host, struct mmc_request *mrq) { unsigned int write_timeout = 0; if(mrq->data != NULL && (mrq->data->flags & MMC_DATA_WRITE) && (mrq->cmd->opcode & MMC_WRITE_MULTIPLE_BLOCK)) { write_timeout = usecs_to_jiffies(mrq->data->timeout_ns/1000) * mrq->data->blocks; wait_for_completion_timeout(&mrq->completion, write_timeout); } else wait_for_completion(&mrq->completion); }
| |