lkml.org 
[lkml]   [2011]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH] xhci: Redundant check for xhci->devs[]
From
Hi Sarah,

This patch is for linux-3.0.3.

In the xhci_check_args() function in xhci.c, there is a redundant
check for xhci->devs.

This is redundant because the struct xhci_hcd->devs is actually
defined as a static array
of pointers and is not a pointer to a pointer.

Signed-off-by: Sifram Rajas <sifram.rajas@gmail.com>
---
drivers/usb/host/xhci.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
--- a/drivers/usb/host/xhci.c 2011-08-17 23:27:16.000000000 +0530
+++ b/drivers/usb/host/xhci.c 2011-08-22 20:43:34.250000000 +0530
@@ -945,8 +945,7 @@ static int xhci_check_args(struct usb_hc
return -ENODEV;

if (check_virt_dev) {
- if (!udev->slot_id || !xhci->devs
- || !xhci->devs[udev->slot_id]) {
+ if (!udev->slot_id || !xhci->devs[udev->slot_id]) {
printk(KERN_DEBUG "xHCI %s called with unaddressed "
"device\n", func);
return -EINVAL;
Thanks,
Sifram Rajas.


\
 
 \ /
  Last update: 2011-08-22 17:39    [W:0.046 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site