Messages in this thread Patch in this message | | | Subject | [PATCH] staging: rts_pstor: dont cast void* from kmalloc() | From | Thomas Meyer <> | Date | Sat, 13 Aug 2011 11:27:10 +0200 |
| |
From: Thomas Meyer <thomas@m3y3r.de>
Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14.
The semantic patch that makes this output is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.
More information about semantic patching is available at http://coccinelle.lip6.fr/
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/drivers/staging/rts_pstor/rtsx_scsi.c b/drivers/staging/rts_pstor/rtsx_scsi.c --- a/drivers/staging/rts_pstor/rtsx_scsi.c 2011-05-05 20:48:37.168211054 +0200 +++ b/drivers/staging/rts_pstor/rtsx_scsi.c 2011-08-01 19:57:16.027347746 +0200 @@ -2730,7 +2730,7 @@ static int get_ms_information(struct scs buf_len = data_len = 0x6A; } - buf = (u8 *)kmalloc(buf_len, GFP_KERNEL); + buf = kmalloc(buf_len, GFP_KERNEL); if (!buf) { TRACE_RET(chip, TRANSPORT_ERROR); }
| |