Messages in this thread | | | Subject | Re: [GIT PULL] iscsi-target merge for v3.1-rc1 | From | "Nicholas A. Bellinger" <> | Date | Tue, 26 Jul 2011 00:51:10 -0700 |
| |
On Tue, 2011-07-26 at 00:43 -0700, Andrew Morton wrote: > On Tue, 26 Jul 2011 00:09:40 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote: > > > Just a simple > > > > #define DIV_ROUND_UP_ULL(ll,d) \ > > ({ unsigned long long _tmp = (ll)+(d)-1; do_div(_tmp, d); _tmp; }) > > > > looks like it would work and be simpler. Avoid the conditional, do the > > same "add 'd-1' thing as the regular ROUND_UP(). > > > > We might end up needing a DIV_ROUND_UP_SECTOR_T because that guy's > type/size is Kconfigurable. > > otoh DIV_ROUND_UP_ULL won't have many callsites - the occasional > conversion from UL to ULL then back to UL wouldn't kill us. Unless > there be subtle problems with such a conversion. >
Makes sense to me, and sending out updated series.. Anything else to consider here folks before pushing into target-pending.git/for-next..?
Thanks!
--nab
| |