lkml.org 
[lkml]   [2011]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] iscsi-target merge for v3.1-rc1
On Tue, 26 Jul 2011 00:09:40 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:

> Just a simple
>
> #define DIV_ROUND_UP_ULL(ll,d) \
> ({ unsigned long long _tmp = (ll)+(d)-1; do_div(_tmp, d); _tmp; })
>
> looks like it would work and be simpler. Avoid the conditional, do the
> same "add 'd-1' thing as the regular ROUND_UP().
>

We might end up needing a DIV_ROUND_UP_SECTOR_T because that guy's
type/size is Kconfigurable.

otoh DIV_ROUND_UP_ULL won't have many callsites - the occasional
conversion from UL to ULL then back to UL wouldn't kill us. Unless
there be subtle problems with such a conversion.



\
 
 \ /
  Last update: 2011-07-26 09:45    [W:0.162 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site