Messages in this thread | | | Date | Mon, 21 Feb 2011 15:51:25 +0200 | Subject | Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h | From | Alexey Dobriyan <> |
| |
On Mon, Feb 21, 2011 at 2:30 PM, Felipe Balbi <balbi@ti.com> wrote: > On Mon, Feb 21, 2011 at 01:05:51PM +0200, Alexey Dobriyan wrote:
>> Just include <linux/sched.h> in your driver. >> This include splitting in small pieces is troublesome as well. > > so, simply to call wake_up*() we need to know everything there is to > know about the scheduler ?
"know everything" is exaggeration. You add sched.h, if someone else haven't added it already via other headers.
File is misnamed, BTW. It should be called task-state.h or something. And, again, TASK_COMM_LEN should be left alone.
> I rather have the split done and kill the circular dependency.
It's not circular for starters.
| |