Messages in this thread | | | Date | Mon, 21 Feb 2011 14:11:42 +0200 | Subject | Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h | From | David Cohen <> |
| |
On Mon, Feb 21, 2011 at 1:05 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote: > On Mon, Feb 21, 2011 at 12:20 PM, David Cohen <dacohen@gmail.com> wrote: >> Currently sched.h and wait.h have circular dependency between both. >> wait.h defines macros wake_up*() which use macros TASK_* defined by >> sched.h. But as sched.h indirectly includes wait.h, such wait.h header >> file can't include sched.h too. The side effect is when some file >> includes wait.h and tries to use its wake_up*() macros, it's necessary >> to include sched.h also. >> This patch moves all TASK_* macros from linux/sched.h to a new header >> file linux/task_sched.h. This way, both sched.h and wait.h can include >> task_sched.h and fix the circular dependency. No need to include sched.h >> anymore when wake_up*() macros are used. > > Just include <linux/sched.h> in your driver.
Sounds a reasonable solution for me.
> This include splitting in small pieces is troublesome as well.
But I disagree it's troublesome. It's transparent to everyone else. The only side effect is to not have to include sched.h when using a macro define on wait.h.
> > Why are you moving TASK_COMM_LEN?
This one can be moved back to sched.h.
Br,
David
> >> include/linux/sched.h | 61 +----------------------------------------- >> include/linux/task_sched.h | 64 ++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/wait.h | 1 + >> 3 files changed, 66 insertions(+), 60 deletions(-) >> create mode 100644 include/linux/task_sched.h > >> --- a/include/linux/sched.h >> +++ b/include/linux/sched.h >> +#include <linux/task_sched.h> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |