Messages in this thread Patch in this message | | | Subject | Re: [PATCH repost 4/4] avr32: at32ap700x: specify DMA src and dst masters | From | Hans-Christian Egtvedt <> | Date | Mon, 21 Feb 2011 14:45:00 +0100 |
| |
On Fri, 2011-01-21 at 14:11 +0000, Jamie Iles wrote: > Now that the dw_dmac DMA driver supports configurable source and > destination masters we need to specify which ones to use. This was > previously hardcoded to 0 and 1 respectively in the driver. > > Cc: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Jamie Iles <jamie@jamieiles.com> > --- > arch/avr32/mach-at32ap/at32ap700x.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c > index e67c999..2747cde 100644 > --- a/arch/avr32/mach-at32ap/at32ap700x.c > +++ b/arch/avr32/mach-at32ap/at32ap700x.c > @@ -2048,6 +2048,8 @@ at32_add_device_ac97c(unsigned int id, struct ac97c_platform_data *data, > rx_dws->reg_width = DW_DMA_SLAVE_WIDTH_16BIT; > rx_dws->cfg_hi = DWC_CFGH_SRC_PER(3); > rx_dws->cfg_lo &= ~(DWC_CFGL_HS_DST_POL | DWC_CFGL_HS_SRC_POL); > + rx_dws->src_master = 0; > + rx_dws->dst_master = 1; > } > > /* Check if DMA slave interface for playback should be configured. */ > @@ -2056,6 +2058,8 @@ at32_add_device_ac97c(unsigned int id, struct ac97c_platform_data *data, > tx_dws->reg_width = DW_DMA_SLAVE_WIDTH_16BIT; > tx_dws->cfg_hi = DWC_CFGH_DST_PER(4); > tx_dws->cfg_lo &= ~(DWC_CFGL_HS_DST_POL | DWC_CFGL_HS_SRC_POL); > + rx_dws->src_master = 0; > + rx_dws->dst_master = 1;
Spotted by Nicolas Ferre, you use the wrong struct here, should be tx_dws, not rx_dws.
<snipp>
-- Hans-Christian Egtvedt
| |