Messages in this thread | | | Date | Mon, 21 Feb 2011 14:17:13 +0100 | From | Lars-Peter Clausen <> | Subject | Re: [tip:irq/core] genirq: Add IRQCHIP_SET_TYPE_MASKED flag |
| |
> @@ -588,11 +596,13 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, > > if (chip != desc->irq_data.chip) > irq_chip_set_defaults(desc->irq_data.chip); > - return 0; > + ret = 0;
I've just tested the patch and noticed that a 'break' is missing here.
> default: > pr_err("setting trigger mode %lu for irq %u failed (%pF)\n", > flags, irq, chip->irq_set_type); > } > + if (unmask) > + unmask_irq(desc); > return ret; > } > > @@ -669,7 +679,7 @@ again: > > #ifdef CONFIG_SMP > /* > - * Check whether we need to change the affinity of the interrupt thread. > + * Check whether we need to chasnge the affinity of the interrupt thread. > */ > static void > irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action)
| |