lkml.org 
[lkml]   [2011]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:irq/core] genirq: Add IRQCHIP_SET_TYPE_MASKED flag
 > @@ -588,11 +596,13 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned
int irq,
>
> if (chip != desc->irq_data.chip)
> irq_chip_set_defaults(desc->irq_data.chip);
> - return 0;
> + ret = 0;

I've just tested the patch and noticed that a 'break' is missing here.


> default:
> pr_err("setting trigger mode %lu for irq %u failed (%pF)\n",
> flags, irq, chip->irq_set_type);
> }
> + if (unmask)
> + unmask_irq(desc);
> return ret;
> }
>
> @@ -669,7 +679,7 @@ again:
>
> #ifdef CONFIG_SMP
> /*
> - * Check whether we need to change the affinity of the interrupt thread.
> + * Check whether we need to chasnge the affinity of the interrupt thread.
> */
> static void
> irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action)



\
 
 \ /
  Last update: 2011-02-21 14:19    [W:0.049 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site