Messages in this thread Patch in this message | | | From | Vasiliy Kulikov <> | Subject | [PATCH] staging: rts_pstor: potential NULL dereference | Date | Wed, 2 Feb 2011 21:29:31 +0300 |
| |
pci_get_bus_and_slot() may return NULL, but the caller checks wrong variable.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> --- Compile tested only.
drivers/staging/rts_pstor/rtsx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rts_pstor/rtsx.c b/drivers/staging/rts_pstor/rtsx.c index 9864b1a..2b18379 100644 --- a/drivers/staging/rts_pstor/rtsx.c +++ b/drivers/staging/rts_pstor/rtsx.c @@ -334,7 +334,7 @@ int rtsx_read_pci_cfg_byte(u8 bus, u8 dev, u8 func, u8 offset, u8 *val) u8 devfn = (dev << 3) | func; pdev = pci_get_bus_and_slot(bus, devfn); - if (!dev) + if (!pdev) return -1; pci_read_config_byte(pdev, offset, &data); -- 1.7.0.4
| |