lkml.org 
[lkml]   [2011]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ramoops: Add a device file for ramoops buffer access.
As I mentioned to Kees on IRC, you probably want to talk to Tony Luck
about his pstore interface, too.

On 11/07/2011 05:04 PM, Bryan Freed wrote:
> Yeah, we should definitely work together on this.
>
> bryan.
>
> On Mon, Nov 7, 2011 at 4:36 PM, Kees Cook <keescook@chromium.org> wrote:
>> Hi Bryan,
>>
>> On Mon, Nov 07, 2011 at 04:06:00PM -0800, Bryan Freed wrote:
>>> Add a /dev/ramoops device file that gives direct access to ramoops buffers.
>>> This interface is cleaner than using /dev/mem to access the buffers because
>>> we no longer need to lseek() or (for ARM) mmap() to an address specified in
>>> the sysfs mem_address file.
>>
>> This looks pretty good, except that I'd also want to remove all the module
>> parameters since this would bypass CONFIG_STRICT_DEVMEM (imagine a
>> malicious root user loading this module to spy on RAM via the new
>> interface).
>>
>> Last week I actually wrote an entire seq_file interface for ramoops[1], but
>> it seems it shouldn't live in /proc, so it needs to be reworked a bit to
>> live in /dev, as you have it.
>>
>> Perhaps we could merge our efforts?
>>
>> -Kees
>>
>> [1] https://gerrit.chromium.org/gerrit/#change,11242
>>
>> --
>> Kees Cook
>> ChromeOS Security
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/



\
 
 \ /
  Last update: 2011-11-08 02:35    [W:0.060 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site