Messages in this thread | | | Date | Mon, 7 Nov 2011 17:04:14 -0800 | Subject | Re: [PATCH] ramoops: Add a device file for ramoops buffer access. | From | Bryan Freed <> |
| |
Yeah, we should definitely work together on this.
bryan.
On Mon, Nov 7, 2011 at 4:36 PM, Kees Cook <keescook@chromium.org> wrote: > Hi Bryan, > > On Mon, Nov 07, 2011 at 04:06:00PM -0800, Bryan Freed wrote: >> Add a /dev/ramoops device file that gives direct access to ramoops buffers. >> This interface is cleaner than using /dev/mem to access the buffers because >> we no longer need to lseek() or (for ARM) mmap() to an address specified in >> the sysfs mem_address file. > > This looks pretty good, except that I'd also want to remove all the module > parameters since this would bypass CONFIG_STRICT_DEVMEM (imagine a > malicious root user loading this module to spy on RAM via the new > interface). > > Last week I actually wrote an entire seq_file interface for ramoops[1], but > it seems it shouldn't live in /proc, so it needs to be reworked a bit to > live in /dev, as you have it. > > Perhaps we could merge our efforts? > > -Kees > > [1] https://gerrit.chromium.org/gerrit/#change,11242 > > -- > Kees Cook > ChromeOS Security >
| |