Messages in this thread | | | From | Stephen Warren <> | Date | Mon, 7 Nov 2011 08:23:29 -0800 | Subject | RE: [PATCH] pinctrl: hide subsystem from the populace |
| |
Linus Walleij wrote at Monday, November 07, 2011 7:15 AM: > From: Linus Walleij <linus.walleij@linaro.org> > > Machines that have embedded pin controllers need to select them > explicitly, so why broadcast their config options to menuconfig. > We provide a helpful submenu for those machines that do select > it, making it possible to enable debugging for example. ... > -menuconfig PINCTRL > - bool "PINCTRL Support" > +config PINCTRL > + bool > depends on EXPERIMENTAL > - help > - This enables the PINCTRL subsystem for controlling pins > - on chip packages, for example multiplexing pins on primarily > - PGA and BGA packages for systems on chip. > - > - If unsure, say N.
This seems OK.
> if PINCTRL > > +menu "Pin controllers" > + depends on PINCTRL > + > config PINMUX > bool "Support pinmux controllers" > help
But shouldn't PINMUX and PINMUX_${soc} also have their help text removed; it seems like if a SoC selects PINCTRL, it would also select PINMUX if appropriate, and the relevant PINMUX_${soc} too?
I assume there are also patches for arch/arm/mach-${foo}/Kconfig somewhere to select PINCTRL when appropriate; they didn't show up in my inbox, but I haven't checked my sub-folders yet, so perhaps they're already there.
-- nvpublic
| |