Messages in this thread Patch in this message | | | Subject | [PATCH] mm: Use kcalloc instead of kzalloc to allocate array | From | Thomas Meyer <> | Date | Tue, 29 Nov 2011 22:08:00 +0100 |
| |
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read.
The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/mm/vmalloc.c b/mm/vmalloc.c --- a/mm/vmalloc.c 2011-11-28 19:36:48.210120310 +0100 +++ b/mm/vmalloc.c 2011-11-28 20:06:49.925235983 +0100 @@ -2348,8 +2348,8 @@ struct vm_struct **pcpu_get_vm_areas(con return NULL; } - vms = kzalloc(sizeof(vms[0]) * nr_vms, GFP_KERNEL); - vas = kzalloc(sizeof(vas[0]) * nr_vms, GFP_KERNEL); + vms = kcalloc(nr_vms, sizeof(vms[0]), GFP_KERNEL); + vas = kcalloc(nr_vms, sizeof(vas[0]), GFP_KERNEL); if (!vas || !vms) goto err_free;
| |