| Date | Fri, 25 Nov 2011 09:59:21 +0100 | From | Lars-Peter Clausen <> | Subject | Re: [PATCH 6/8] ASoC: SigmaDSP: Provide diagnostic error messages |
| |
On 11/24/2011 06:32 PM, Mike Frysinger wrote: > On Thursday 24 November 2011 07:48:25 Lars-Peter Clausen wrote: >> + if (crc != le32_to_cpu(ssfw_head->crc)) { >> + dev_err(&client->dev, "Failed to load firmware: Wrong crc checksum:" \ >> + " expected %x got %x.\n", > > it's my understanding that string constants should not be split > -mike
I think it is fine here. You probably wouldn't grep for %x anyway.
|