lkml.org 
[lkml]   [2011]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/8] ASoC: SigmaDSP: Provide diagnostic error messages
On 11/24/2011 06:32 PM, Mike Frysinger wrote:
> On Thursday 24 November 2011 07:48:25 Lars-Peter Clausen wrote:
>> + if (crc != le32_to_cpu(ssfw_head->crc)) {
>> + dev_err(&client->dev, "Failed to load firmware: Wrong crc checksum:" \
>> + " expected %x got %x.\n",
>
> it's my understanding that string constants should not be split
> -mike

I think it is fine here. You probably wouldn't grep for %x anyway.


\
 
 \ /
  Last update: 2011-11-25 10:01    [W:0.295 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site