lkml.org 
[lkml]   [2011]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 6/8] ASoC: SigmaDSP: Provide diagnostic error messages
Date
On Friday 25 November 2011 03:59:21 Lars-Peter Clausen wrote:
> On 11/24/2011 06:32 PM, Mike Frysinger wrote:
> > On Thursday 24 November 2011 07:48:25 Lars-Peter Clausen wrote:
> >> + if (crc != le32_to_cpu(ssfw_head->crc)) {
> >> + dev_err(&client->dev, "Failed to load firmware: Wrong crc
checksum:"
> >> \ + " expected %x got %x.\n",
> >
> > it's my understanding that string constants should not be split
>
> I think it is fine here. You probably wouldn't grep for %x anyway.

no, but you would copy and paste a string like:
"Failed to load firmware: Wrong crc checksum: expected"
and then not find a match

i think it's best to follow the style anyways ...

also, no need for the period at the end of the msg. that's useless noise and
can be annoying to copying & pasting numbers.
-mike
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-11-25 21:05    [W:0.117 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site