lkml.org 
[lkml]   [2011]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 1/3] procfs: parse mount options
Hi Américo,

On Tue, Nov 15, 2011 at 19:48 +0800, Américo Wang wrote:
> On Tue, Nov 15, 2011 at 7:21 PM, Vasiliy Kulikov <segoon@openwall.com> wrote:
> > +
> > +static int proc_parse_options(char *options, struct pid_namespace *pid)
> > +{
> > +       char *p;
> > +       substring_t args[MAX_OPT_ARGS];
> > +       int option;
>
>
> 'option' is unused?

Right.

> > +               switch (token) {
> > +               default:
>
>
> This switch block reads odd...

It will be used in 2/3 patch.

> > +                       pr_err("proc: unrecognized mount option \"%s\" "
> > +                              "or missing value", p);
>
> "\n" is needed.

Correct. Thank you!

> > +                       return 0;
> > +               }
> > +       }
> > +
> > +       return 1;
> > +}

--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-11-15 13:59    [W:0.031 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site