Messages in this thread | | | Date | Tue, 15 Nov 2011 19:48:15 +0800 | Subject | Re: [RFC 1/3] procfs: parse mount options | From | Américo Wang <> |
| |
On Tue, Nov 15, 2011 at 7:21 PM, Vasiliy Kulikov <segoon@openwall.com> wrote: > + > +static int proc_parse_options(char *options, struct pid_namespace *pid) > +{ > + char *p; > + substring_t args[MAX_OPT_ARGS]; > + int option;
'option' is unused?
> + > + pr_debug("proc: options = %s\n", options); > + > + if (!options) > + return 1; > + > + while ((p = strsep(&options, ",")) != NULL) { > + int token; > + if (!*p) > + continue; > + > + args[0].to = args[0].from = 0; > + token = match_token(p, tokens, args); > + switch (token) { > + default:
This switch block reads odd...
> + pr_err("proc: unrecognized mount option \"%s\" " > + "or missing value", p);
"\n" is needed.
> + return 0; > + } > + } > + > + return 1; > +}
Regards.
| |