Messages in this thread Patch in this message | | | Date | Mon, 14 Nov 2011 18:42:32 -0800 (PST) | From | Alex Davis <> | Subject | [PATCH] i915: Fix bug where screen brightness is not restored |
| |
From: Alex Davis<alex14641@yahoo.com>
This patch fixes an issue where the screen would remain dark when
a key was pressed when the laptop lid was reopened or after the laptop had gone into power-save mode.
It seems that there are a number of people with different machines that have this problem:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/872652 https://launchpad.net/~kamalmostafa/+archive/stuck-backlight and https://bugs.freedesktop.org/show_bug.cgi?id=41926
This patch is against Linux 3.1
Putting printk's in ./drivers/gpu/drm/i915/intel_panel.c showed that intel_get_brightness was being called after the panel was disabled, which caused a 0 to be saved as the value to restore the brightness. intel_panel_disable_backlight merely sets the brightness to 0. Commenting out this call allows the correct brightness value to be saved.
Signed-off-by: Alex Davis <alex14641@yahoo.com> Tested-by: Kamal Mostafa <kamal@canonical.com> ----- diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index a9e0c7b..6f56676 100644 --- a/drivers/gpu/drm/i915/intel_panel.c +++ b/drivers/gpu/drm/i915/intel_panel.c @@ -262,8 +262,6 @@ void intel_panel_disable_backlight(struct drm_device *dev) dev_priv->backlight_level = intel_panel_get_backlight(dev); dev_priv->backlight_enabled = false; } - - intel_panel_set_backlight(dev, 0); }
void intel_panel_enable_backlight(struct drm_device *dev)
I code, therefore I am -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |