Messages in this thread Patch in this message | | | From | David Ahern <> | Subject | [PATCH] perf tools: fix crash with invalid CPU list | Date | Sun, 13 Nov 2011 10:45:27 -0700 |
| |
commit 5d67be9 added the option to specify a range of CPUs of interest, but does not catch an invalid CPU list:
$ perf script -c foo Segmentation fault (core dumped)
Signed-off-by: David Ahern <dsahern@gmail.com> --- tools/perf/util/session.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 85c1e6b7..0f4555c 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1333,6 +1333,10 @@ int perf_session__cpu_bitmap(struct perf_session *session, } map = cpu_map__new(cpu_list); + if (map == NULL) { + pr_err("Invalid cpu_list\n"); + return -1; + } for (i = 0; i < map->nr; i++) { int cpu = map->map[i]; -- 1.7.7.1
| |