lkml.org 
[lkml]   [2011]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [bisected][bug] commit e978aa7d7d57d04eb5f88 breaks suspend on laptop.
Date
On Saturday, November 12, 2011, Rafael J. Wysocki wrote:
> If that's "acpi_idle", the appended patch should help (it works for
> me at least).

Hi Rafael,

I currently have limited email connectivity but I happened to bisect the
same bug and your patch fixes it for me. I am certainly on acpi_idle
with my thinkpad w500.

Sorry for breaking the email threading and dropping people from Cc.

> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: ACPI / cpuidle: Remove acpi_idle_suspend (to fix suspend regression)
> After commit e978aa7d7d57d04eb5f88a7507c4fb98577def77 (cpuidle: Move
> dev->last_residency update to driver enter routine; remove
> dev->last_state) setting acpi_idle_suspend to 1 by
> acpi_processor_suspend() causes the ACPI cpuidle routines to return
> error codes continuously, which in turn causes cpuidle to lock up
> (hard). However, acpi_idle_suspend doesn't appear to be useful for
> any purpose (it's racy and doesn't really provide any real
> protection), so it can be removed, which makes the problem go away.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

Tested-by: Arnd Bergmann <arnd@arndb.de>

Arnd


\
 
 \ /
  Last update: 2011-11-12 04:47    [W:0.039 / U:1.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site