Messages in this thread | | | Date | Thu, 13 Oct 2011 17:04:47 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH] i7core_edac: fix erroneous size of static array |
| |
Em 13-10-2011 16:14, Borislav Petkov escreveu: > On Thu, Oct 13, 2011 at 03:03:20PM -0400, Luck, Tony wrote: >>> - static int cols[8] = { >>> + static int cols[4] = { >> >> Why are these arrays "static"? Does that generate better code than >> dynamic initialization? > > They look like lookup arrays for count of things based on bit settings > and as such they should be static because they don't ... change :). If > they were dynamic, then inlining them in every function callsite would > be not cool.
Btw, it probably makes sense to also declare as "const". In this specific case, it is likely that gcc will discover that it is const anyway, and do some optimization, but sometimes gcc don't do what I would expect ;)
Mauro.
| |