Messages in this thread | | | Date | Thu, 13 Oct 2011 21:14:48 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] i7core_edac: fix erroneous size of static array |
| |
On Thu, Oct 13, 2011 at 03:03:20PM -0400, Luck, Tony wrote: > > - static int cols[8] = { > > + static int cols[4] = { > > Why are these arrays "static"? Does that generate better code than > dynamic initialization?
They look like lookup arrays for count of things based on bit settings and as such they should be static because they don't ... change :). If they were dynamic, then inlining them in every function callsite would be not cool.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |