Messages in this thread | | | Date | Mon, 10 Oct 2011 10:52:50 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/1] drivers: staging: rts_pstor fixed checkpatch warnings |
| |
On Mon, Oct 10, 2011 at 07:42:17AM +0200, Pelle Windestam wrote: > -static struct pci_device_id rtsx_ids[] = { > - { 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 }, > - { 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 }, > - { 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 }, > +static DEFINE_PCI_DEVICE_TABLE(rtsx_ids) = { > + { 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID, > + PCI_CLASS_OTHERS << 16, 0xFF0000 }, > + { 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID, > + PCI_CLASS_OTHERS << 16, 0xFF0000 }, > + { 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID, > + PCI_CLASS_OTHERS << 16, 0xFF0000 }, > { 0, }, > };
This looked nicer in the original version. I know that checkpatch complains but in the end, checkpatch is just a perl script. It's less sentient than a squirrel.
regards, dan carpenter
| |