lkml.org 
[lkml]   [2011]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] drivers: staging: rts_pstor fixed checkpatch warnings
On Mon, Oct 10, 2011 at 07:42:17AM +0200, Pelle Windestam wrote:
> -static struct pci_device_id rtsx_ids[] = {
> - { 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 },
> - { 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 },
> - { 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 },
> +static DEFINE_PCI_DEVICE_TABLE(rtsx_ids) = {
> + { 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID,
> + PCI_CLASS_OTHERS << 16, 0xFF0000 },
> + { 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID,
> + PCI_CLASS_OTHERS << 16, 0xFF0000 },
> + { 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID,
> + PCI_CLASS_OTHERS << 16, 0xFF0000 },
> { 0, },
> };

This looked nicer in the original version. I know that checkpatch
complains but in the end, checkpatch is just a perl script. It's
less sentient than a squirrel.

regards,
dan carpenter


\
 
 \ /
  Last update: 2011-10-10 09:57    [W:0.036 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site