Messages in this thread | | | Subject | Re: [PATCH 1/1] drivers: staging: rts_pstor fixed checkpatch warnings | From | Joe Perches <> | Date | Mon, 10 Oct 2011 09:13:21 -0700 |
| |
On Mon, 2011-10-10 at 17:14 +0200, Pelle Windestam wrote: > On Mon, Oct 10, 2011 at 9:52 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > This looked nicer in the original version. I know that checkpatch > > complains but in the end, checkpatch is just a perl script. It's > > less sentient than a squirrel.
I agree.
That's good happy cheery imagery Dan, but I might have chosen a cockroach too.
> I have to agree with you on that, but I wasn't sure how strictly to > follow the checkpatch warnings. I'll happily resubmit the patch > without this change if nobody minds.
> -static struct pci_device_id rtsx_ids[] = { > - { 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 }, > - { 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 }, > - { 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 }, > +static DEFINE_PCI_DEVICE_TABLE(rtsx_ids) = { > + { 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID, > + PCI_CLASS_OTHERS << 16, 0xFF0000 }, > + { 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID, > + PCI_CLASS_OTHERS << 16, 0xFF0000 }, > + { 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID, > + PCI_CLASS_OTHERS << 16, 0xFF0000 }, > { 0, },
Maybe use PCI_DEVICE
static DEFINE_PCI_DEVICE_TABLE(rtsx_ids) = { { PCI_DEVICE(0x10EC, 0x5208), PCI_CLASS_OTHERS << 16, 0xFF0000 }, { PCI_DEVICE(0x10EC, 0x5209), PCI_CLASS_OTHERS << 16, 0xFF0000 }, { PCI_DEVICE(0x10EC, 0x5288), PCI_CLASS_OTHERS << 16, 0xFF0000 }, { 0, },
You could also substitute PCI_VENDOR_ID_REALTEK for 0x10ec
| |