Messages in this thread | | | Date | Mon, 10 Oct 2011 22:04:23 +0530 | From | Rajendra Nayak <> | Subject | Re: [PATCH v2 1/5] regulator: twl: Remove hardcoded board constraints from driver |
| |
On Monday 10 October 2011 09:55 PM, Mark Brown wrote: > On Mon, Oct 10, 2011 at 09:49:34PM +0530, Rajendra Nayak wrote: >> Remove the hardcoded .valid_modes_mask and .valid_ops_mask for >> each regulator from the twl driver and let the boards pass it. >> >> Signed-off-by: Rajendra Nayak<rnayak@ti.com> >> Acked-by: Mark Brown<broonie@opensource.wolfsonmicro.com> > > Please update this changelog - as I said in reply to your previous > posting this isn't actually hardcoding anything, it's dropping things > from the constraints which the hardware doesn't support.
Looks like I completely missed the "&=" and your comment on the previous posting. Looking at it now, seems to me this patch is just un-necessary and what the driver seems to be doing (preventing users from setting flags which the hardware does not support) seems perfectly fine. I will just go ahead and drop this patch.
| |