Messages in this thread Patch in this message | | | Date | Tue, 29 Jun 2010 23:02:26 +0530 | From | Srikar Dronamraju <> | Subject | [Bugfix] [2.6.35-rc3-tip] perf build failure on latest tip. |
| |
When compiling perf on latest tip/master I see the following error
cc1: warnings being treated as errors util/newt.c: In function âhist_entry__tui_annotateâ: util/newt.c:764: warning: âretâ is used uninitialized in this function make: *** [util/newt.o] Error 1
I think the problem was introduced by commit 13f499f076c67675e6e3022973729b5d906a84e9
Below is a patch that fixes the problem.
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> ---
diff --git a/tools/perf/util/newt.c b/tools/perf/util/newt.c index 89c52fc..06f248f 100644 --- a/tools/perf/util/newt.c +++ b/tools/perf/util/newt.c @@ -753,7 +753,7 @@ int hist_entry__tui_annotate(struct hist_entry *self) browser.width += 18; /* Percentage */ ui_browser__show(&browser, self->ms.sym->name); - ui_browser__run(&browser, &es); + ret = ui_browser__run(&browser, &es); newtFormDestroy(browser.form); newtPopWindow(); list_for_each_entry_safe(pos, n, &head, node) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |