lkml.org 
[lkml]   [2010]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: USB transfer_buffer allocations on 64bit systems
Date
Am Freitag, 9. April 2010 16:41:48 schrieb Alan Stern:
> > It'll work on x86. On incoherent architectures this violates the cacheline
> > rules for DMA-mapping if you have to bounce.
>
> Not true. Consider: The driver allocates a 16-byte buffer (xbuf)
> divided up into four sets of four bytes, and sets
>
> urb[i].transfer_buffer_dma = xbuf_dma + 4*i;
>
> Then usb_submit_urb(urb[i]) will copy the appropriate four bytes to a
> bounce buffer and map the bounce buffer. Accesses to the other parts
> of xbuf won't violate the cacheline rules, because xbuf isn't mapped
> for DMA -- only the bounce buffer is. When urb[i] completes, the
> bounce buffer contents will be copied back to the original four bytes
> in xbuf. Again, there is no violation of cacheline rules.

I think you are assuming that either every or no part of the buffer is mapped
for DMA in place. I don't think you can assume that.

Regards
Oliver


\
 
 \ /
  Last update: 2010-04-09 16:53    [W:0.111 / U:1.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site