Messages in this thread Patch in this message | | | Date | Mon, 26 Apr 2010 12:33:03 -0400 | From | Rik van Riel <> | Subject | [PATCH] mmap: check ->vm_ops before dereferencing |
| |
Check whether the VMA has a vm_ops before calling close, just like we check vm_ops before calling open a few dozen lines higher up in the function.
Signed-off-by: Rik van Riel <riel@redhat.com> Reported-by: Dan Carpenter <error27@gmail.com>
diff --git a/mm/mmap.c b/mm/mmap.c index f90ea92..456ec6f 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1977,7 +1977,8 @@ static int __split_vma(struct mm_struct * mm, struct vm_area_struct * vma, return 0; /* Clean everything up if vma_adjust failed. */ - new->vm_ops->close(new); + if (new->vm_ops && new->vm_ops->close) + new->vm_ops->close(new); if (new->vm_file) { if (vma->vm_flags & VM_EXECUTABLE) removed_exe_file_vma(mm);
| |