Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 23 Apr 2010 15:02:07 -0700 | From | Stephen Hemminger <> | Subject | Re: [PATCH] e100: expose broadcast_disabled as a module option |
| |
On Fri, 23 Apr 2010 23:03:59 +0200 Erwan Velu <erwanaliasr1@gmail.com> wrote:
> I first tried "ifconfig -broadcast" without any success, so I forced > the driver to unset IFF_BROADCAST, the interface didn't showed anymore > the BROADCAST option with ifconfig. But I didn't noticed any reduction > in the amount of context/switches on my host. > > I found the broadcast_disabled far more efficient when considering the > cpu impact.
The point is that the driver can look at IFF_BROADCAST rather than having module parameter. Module parameters are device driver specific and should be avoid as much as possible in favor of general mechanism. This is a repeated problem where users and vendors make special hooks that only work with their driver, which makes life hard for other users and distribution providers.
| ![\](/images/icornerr.gif) |