Messages in this thread | | | Date | Thu, 22 Apr 2010 11:13:21 +1000 (EST) | From | Finn Thain <> | Subject | Re: [PATCH] mac8390: change an error return code and some cleanup, take 3 |
| |
On Wed, 21 Apr 2010, David Miller wrote:
> From: Finn Thain <fthain@telegraphics.com.au> > Date: Sat, 17 Apr 2010 13:16:04 +1000 (EST) > > > > > Change an error return code from -EAGAIN to -EBUSY since the former is > > misleading. > > > > Nubus slots are geographically addressed and their irqs are equally > > inflexible. -EAGAIN is misleading because retrying will not help fix > > whatever bug it was that made the irq unavailable. > > request_irq() itself returns an appropriate error code, so the > correct change is to do: > > err = request_irq( ... ); > if (err) { > ... > > and return 'err'.
OK. I'll send a new patch once 2.6.34 is out and I have time to test this and some other patches.
Finn
| |