Messages in this thread | | | Date | Wed, 21 Apr 2010 16:30:41 -0700 (PDT) | Subject | Re: [PATCH] mac8390: change an error return code and some cleanup, take 3 | From | David Miller <> |
| |
From: Finn Thain <fthain@telegraphics.com.au> Date: Sat, 17 Apr 2010 13:16:04 +1000 (EST)
> > Change an error return code from -EAGAIN to -EBUSY since the former is > misleading. > > Nubus slots are geographically addressed and their irqs are equally > inflexible. -EAGAIN is misleading because retrying will not help fix > whatever bug it was that made the irq unavailable.
request_irq() itself returns an appropriate error code, so the correct change is to do:
err = request_irq( ... ); if (err) { ...
and return 'err'.
| |