Messages in this thread | | | Date | Tue, 20 Apr 2010 12:52:25 -0400 | From | Jeff Dike <> | Subject | Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition |
| |
On Tue, Apr 20, 2010 at 04:35:52PM +0200, Jiri Kosina wrote: > On Tue, 20 Apr 2010, Amerigo Wang wrote: > > Shouldn't this signal.c #include <linux/kernel.h>? > > Well, it gets included implicitly through uaccess.h -> sched.h -> > kernel.h.
You're depending on the internal details of uaccess.h and sched.h. If either of them changed, then this would cause unexpected compile failures here.
Better to explicitly include kernel.h.
Jeff
-- Work email - jdike at linux dot intel dot com
| |