Messages in this thread | | | Date | Tue, 20 Apr 2010 17:49:28 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH 2/5] uml: Drop private round_down definition |
| |
On Tue, 20 Apr 2010, Jeff Dike wrote:
> > >Already defined in kernel.h. The official version assumes that 'n' is > > >power of two - which it is in our case. > > > > > >Signed-off-by: Jan Kiszka <jan.kiszka@web.de> > > >--- > > > arch/um/sys-x86_64/signal.c | 2 -- > > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > > >diff --git a/arch/um/sys-x86_64/signal.c b/arch/um/sys-x86_64/signal.c > > >index 1a899a7..07797d1 100644 > > >--- a/arch/um/sys-x86_64/signal.c > > >+++ b/arch/um/sys-x86_64/signal.c > > >@@ -165,8 +165,6 @@ struct rt_sigframe > > > struct _fpstate fpstate; > > > }; > > > > > >-#define round_down(m, n) (((m) / (n)) * (n)) > > >- > > > int setup_signal_stack_si(unsigned long stack_top, int sig, > > > struct k_sigaction *ka, struct pt_regs * regs, > > > siginfo_t *info, sigset_t *set) > > > > Shouldn't this signal.c #include <linux/kernel.h>? > > I agree - if this is going to depend on kernel.h, it should be > explicitly included.
Yup, I have already added that.
Thanks,
-- Jiri Kosina SUSE Labs, Novell Inc.
| |