Messages in this thread | | | Date | Fri, 16 Apr 2010 09:26:52 +0200 | From | Andreas Herrmann <> | Subject | Re: useless node/has_cpu sysfs attribute |
| |
On Thu, Apr 15, 2010 at 07:27:42PM -0500, Christoph Lameter wrote: > On Thu, 15 Apr 2010, Andreas Herrmann wrote: > > > commit 99dcc3e5a94ed491fbef402831d8c0bbb267f995 (this_cpu: Page > > allocator conversion) removed the call > > > > node_set_state(node, N_CPU); /* this node has a cpu */
> This was moved to vmstat_cpuup_callback. See mm/vmstat.c. Maybe it needs > to be added to setup_vmstat() as well.
Ok. I missed that one.
> > Thus the sysfs attribute /sys/devices/system/node/has_cpu doesn't > > show anything anymore. > > Thats strange. Why is the cpuup notifier not executing?
I'll try to figure this out.
> > This attribute never reflected any changes triggered by CPU hotplug. > > Duh some breakage in the cpuup notifier handling? > > This needs to be fixed.
Why don't we try to call node_clear_state(node, N_CPU) anywhere? (Maybe there is such a call and I missed it.)
Do we want to list each node with this attribute that has a CPU regardless whether the CPU is actually offline or online?
That is the reason why I wanted to know who is relying on this attribute and what are the use cases of it.
Thanks, Andreas
| |