lkml.org 
[lkml]   [2010]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: useless node/has_cpu sysfs attribute
On Thu, 15 Apr 2010, Andreas Herrmann wrote:

> commit 99dcc3e5a94ed491fbef402831d8c0bbb267f995 (this_cpu: Page
> allocator conversion) removed the call
>
> node_set_state(node, N_CPU); /* this node has a cpu */

This was moved to vmstat_cpuup_callback. See mm/vmstat.c. Maybe it needs
to be added to setup_vmstat() as well.

> Thus the sysfs attribute /sys/devices/system/node/has_cpu doesn't
> show anything anymore.

Thats strange. Why is the cpuup notifier not executing?

> This attribute never reflected any changes triggered by CPU hotplug.

Duh some breakage in the cpuup notifier handling?

This needs to be fixed.


\
 
 \ /
  Last update: 2010-04-16 02:35    [W:0.022 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site