Messages in this thread Patch in this message | | | From | Frederic Weisbecker <> | Subject | [PATCH] random: Forbid llseek on random chardev | Date | Sat, 10 Apr 2010 16:17:44 +0200 |
| |
From: Arnd Bergmann <arnd@arndb.de>
Seeking on /dev/random and /dev/urandom is pointless. Using generic_file_llseek means we no longer need to take the BKL if anyone tries to seek on these.
Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Matt Mackall <mpm@selenic.com> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> --- drivers/char/random.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c index 2fd3d39..513c685 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -1169,6 +1169,7 @@ const struct file_operations random_fops = { .poll = random_poll, .unlocked_ioctl = random_ioctl, .fasync = random_fasync, + .open = nonseekable_open, }; const struct file_operations urandom_fops = { @@ -1176,6 +1177,7 @@ const struct file_operations urandom_fops = { .write = random_write, .unlocked_ioctl = random_ioctl, .fasync = random_fasync, + .open = nonseekable_open, }; /*************************************************************** -- 1.6.2.3
| |