Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Thu, 1 Apr 2010 13:04:46 -0700 | From | Andrew Isaacson <> | Subject | [PATCH] perf: timechart: handle pthreads correctly |
| |
pthreads applications have multiple processes with the same "pid" but different "tid" values. This confuses timechart, because it's using the "pid" value to track processes.
Switch to using "tid" to avoid this confusion. For non-pthreads applications tid == pid so there's no downside.
Signed-off-by: Andy Isaacson <adi@vmware.com>
--- I've attached a before.svg.gz and after.svg.gz showing the failure.
diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index 0d4d8ff..5b925de 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c @@ -286,7 +286,7 @@ static int process_comm_event(event_t *event, struct perf_session *session __use static int process_fork_event(event_t *event, struct perf_session *session __used) { - pid_fork(event->fork.pid, event->fork.ppid, event->fork.time); + pid_fork(event->fork.tid, event->fork.ppid, event->fork.time); return 0; } [unhandled content-type:application/octet-stream][unhandled content-type:application/octet-stream] | ![\](/images/icornerr.gif) |