lkml.org 
[lkml]   [2010]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/9] fs/quota/dquot.c: Use printf extension %pV
On Tue 09-11-10 16:35:22, Joe Perches wrote:
> Using %pV reduces the number of printk calls and
> eliminates any possible message interleaving from
> other printk calls.
Thanks. Merged.

Honza

>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> fs/quota/dquot.c | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index 0fed41e..aad97ef 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -135,14 +135,18 @@ EXPORT_SYMBOL(dq_data_lock);
> void __quota_error(struct super_block *sb, const char *func,
> const char *fmt, ...)
> {
> + struct va_format vaf;
> va_list args;
>
> if (printk_ratelimit()) {
> va_start(args, fmt);
> - printk(KERN_ERR "Quota error (device %s): %s: ",
> - sb->s_id, func);
> - vprintk(fmt, args);
> - printk("\n");
> +
> + vaf.fmt = fmt;
> + vaf.va = &args;
> +
> + printk(KERN_ERR "Quota error (device %s): %s: %pV\n",
> + sb->s_id, func, &vaf);
> +
> va_end(args);
> }
> }
> --
> 1.7.3.1.g432b3.dirty
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2010-11-10 02:03    [W:0.105 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site