Messages in this thread Patch in this message | | | From | Joe Perches <> | Subject | [PATCH 6/9] fs/gfs2/glock.c: Use printf extension %pV | Date | Tue, 9 Nov 2010 16:35:20 -0800 |
| |
Using %pV reduces the number of printk calls and eliminates any possible message interleaving from other printk calls.
Signed-off-by: Joe Perches <joe@perches.com> --- fs/gfs2/glock.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 8777885..d30b39c 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -952,17 +952,22 @@ int gfs2_glock_wait(struct gfs2_holder *gh) void gfs2_print_dbg(struct seq_file *seq, const char *fmt, ...) { + struct va_format vaf; va_list args; va_start(args, fmt); + if (seq) { struct gfs2_glock_iter *gi = seq->private; vsprintf(gi->string, fmt, args); seq_printf(seq, gi->string); } else { - printk(KERN_ERR " "); - vprintk(fmt, args); + vaf.fmt = fmt; + vaf.va = &args; + + printk(KERN_ERR " %pV", &vaf); } + va_end(args); } -- 1.7.3.1.g432b3.dirty
| |