lkml.org 
[lkml]   [2010]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] serial/ce4100: Add PCI UART support for the ce4100
On Tue, Nov 09, 2010 at 12:08:06PM -0800, dirk.brandewie@gmail.com wrote:
> From: Dirk Brandewie <dirk.brandewie@gmail.com>
>
> This patch adds support for the PCI UART on the ce4100.
>
> Signed-off-by: Dirk Brandewie <dirk.brandewie@gmail.com>
> CC: linux-serial@vger.kernel.org
> ---
> drivers/serial/8250_pci.c | 35 +++++++++++++++++++++++++++++++++++
> include/linux/pci_ids.h | 1 +

You did read the top of pci_ids.h right? Why are you adding new ids
that are only used by one file?

Please don't do that.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-11-09 22:17    [W:0.101 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site