Messages in this thread | | | Date | Tue, 9 Nov 2010 13:14:18 -0800 | From | Greg KH <> | Subject | Re: [PATCH 3/6] serial/ce4100: Add PCI UART support for the ce4100 |
| |
On Tue, Nov 09, 2010 at 12:08:06PM -0800, dirk.brandewie@gmail.com wrote: > From: Dirk Brandewie <dirk.brandewie@gmail.com> > > This patch adds support for the PCI UART on the ce4100. > > Signed-off-by: Dirk Brandewie <dirk.brandewie@gmail.com> > CC: linux-serial@vger.kernel.org > --- > drivers/serial/8250_pci.c | 35 +++++++++++++++++++++++++++++++++++ > include/linux/pci_ids.h | 1 +
You did read the top of pci_ids.h right? Why are you adding new ids that are only used by one file?
Please don't do that.
thanks,
greg k-h
| |